prasanthj commented on a change in pull request #1858:
URL: https://github.com/apache/hive/pull/1858#discussion_r558815600
##########
File path: llap-server/src/main/resources/llap-daemon-log4j2.properties
##########
@@ -81,23 +81,21 @@ appender.query-routing.type = Routing
appender.query-routing.name = query-routing
appender.query-routing.routes.type = Routes
appender.query-routing.routes.pattern = $${ctx:queryId}
-#Purge polciy for query-based Routing Appender
-appender.query-routing.purgePolicy.type = LlapRoutingAppenderPurgePolicy
-# Note: Do not change this name without changing the corresponding entry in
LlapConstants
-appender.query-routing.purgePolicy.name = llapLogPurgerQueryRouting
+#Purge policy for query-based Routing Appender
+appender.query-routing.purgePolicy.type = IdlePurgePolicy
+appender.query-routing.purgePolicy.timeToLive = 5
Review comment:
Yes. 5 sec is too low. I would keep give it atleast 30 or 60s. Also I
remember the log router will rename the files with .done suffix to mark the
completion of query and hence the log file. Does it still happen? If we no
longer follow the filename convention it will be worth checking if other
consumers are expecting files with .done suffix (yarn log aggregation, twz ui)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
