kgyrtkirk commented on a change in pull request #1875: URL: https://github.com/apache/hive/pull/1875#discussion_r559550634
########## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ########## @@ -1806,6 +1806,12 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal // CBO related HIVE_CBO_ENABLED("hive.cbo.enable", true, "Flag to control enabling Cost Based Optimizations using Calcite framework."), + HIVE_CBO_FALLBACK_STRATEGY("hive.cbo.fallback.strategy", "CONSERVATIVE", new StringSet("NEVER, CONSERVATIVE, ALWAYS, TEST"), Review comment: this seem like the stringset has only one value which is `NEVER, CONSERVATIVE, ALWAYS, TEST` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org