deniskuzZ commented on a change in pull request #1893:
URL: https://github.com/apache/hive/pull/1893#discussion_r561026453



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -2620,18 +2622,18 @@ public static void listFilesInsideAcidDirectory(Path 
acidDir, FileSystem srcFs,
     }
   }
 
-  private void listFilesCreatedByQuery(Path loadPath, long writeId, int 
stmtId, boolean isInsertOverwrite,
-      List<Path> newFiles) throws HiveException {
+  private List<FileStatus> listFilesCreatedByQuery(Path loadPath, long 
writeId, int stmtId) throws HiveException {

Review comment:
       Can we return List'<'Path'>' to avoid extra map(FileStatus::getPath) and 
collect in the method usages?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to