abstractdog commented on a change in pull request #1798:
URL: https://github.com/apache/hive/pull/1798#discussion_r562100712
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java
##########
@@ -278,7 +284,7 @@ public Kryo create() {
* @return kryo instance
*/
public static Kryo borrowKryo() {
- Kryo kryo = kryoPool.borrow();
+ Kryo kryo = kryoPool.obtain();
Review comment:
it's very unfortunate that kryo changed this method name without any
reasons (or just I don't understand that :) )...we might want a method name
that reflects the behavior of "getting a kryo instance from the pool", I don't
have a strong opinion about that, but I'm not sure if we need to change a
public method name because kryo changed theirs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
