kgyrtkirk commented on a change in pull request #1870:
URL: https://github.com/apache/hive/pull/1870#discussion_r561895307



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java
##########
@@ -39,7 +40,16 @@
   }
 
   private abstract static class BaseUpdateFunction implements UpdateFunction {
-    private static final int PRINT_INTERVAL = 3000;
+    private static final long PRINT_INTERVAL;
+
+    static {

Review comment:
       I think instead of initializing this from a vanilla `new HiveConf` in a 
static block - we should access this setting from the constructor thru the 
`monitor` which seem to have a `hiveconf` field
   
   cc: @abstractdog 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to