jcamachor commented on a change in pull request #1892:
URL: https://github.com/apache/hive/pull/1892#discussion_r564004991
##########
File path:
itests/hive-blobstore/src/test/results/clientpositive/insert_into_dynamic_partitions.q.out
##########
@@ -100,7 +100,7 @@ STAGE PLANS:
Statistics: Num rows: 1 Data size: 10 Basic stats: COMPLETE Column
stats: COMPLETE
GatherStats: false
Select Operator
- expressions: array(const struct(1,'101'),const
struct(2,'202'),const struct(3,'303'),const struct(4,'404'),const
struct(5,'505')) (type: array<struct<col1:int,col2:string>>)
+ expressions:
array(named_struct('col1',1,'col2','101'),named_struct('col1',2,'col2','202'),named_struct('col1',3,'col2','303'),named_struct('col1',4,'col2','404'),named_struct('col1',5,'col2','505'))
(type: array<struct<col1:int,col2:string>>)
Review comment:
This should not change, i.e., it seems we are failing to recognize
constant structs now. Iirc this is important because there are specific
optimization on execution for some of these specific data structures (also for
translation to other engines). The consolidation could possibly be done in
constant folding (`ConstantPropagateProcFactory`) if the changes in the parser
need to be done this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
