mustafaiman commented on a change in pull request #1902:
URL: https://github.com/apache/hive/pull/1902#discussion_r565557991
##########
File path:
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
##########
@@ -348,13 +348,13 @@ public CompareCliConfig() {
}
}
- public static class NegativeCliConfig extends AbstractCliConfig {
- public NegativeCliConfig() {
+ public static class NegativeLlapLocalCliConfig extends AbstractCliConfig {
Review comment:
I did not understand your point. I just renamed the old drivers. I had
to rename NegativeMinimr because it has "mr" in it. I admittedly did not have
to rename NegativeCliDriver. I changed that one to make the naming consistent
with other drivers (MiniLlapCliDriver and MiniLlapLocalCliDriver). Also, all 4
llap drivers use the same config directory. It is easier to identify they all
use the same runtime with similar names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
