kgyrtkirk commented on a change in pull request #1916:
URL: https://github.com/apache/hive/pull/1916#discussion_r566019804
##########
File path: pom.xml
##########
@@ -1360,6 +1360,13 @@
</bannedImports>
<includeTestCode>true</includeTestCode>
</restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.RestrictImports">
+ <reason>Do not use commons-logging; use slf4j</reason>
+ <bannedImports>
+ <bannedImport>org.apache.commons.logging.**</bannedImport>
Review comment:
okay; removing commons-logging usage is usefull initself ; and that NDC
usage is interesting - might worth open a separate ticket to investigate that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
