zeroflag commented on a change in pull request #1733:
URL: https://github.com/apache/hive/pull/1733#discussion_r566794345
##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -1460,7 +1495,26 @@ public Integer
visitCreate_procedure_stmt(HplsqlParser.Create_procedure_stmtCont
addLocalUdf(ctx); // Add procedures as they can be
invoked by functions
return 0;
}
-
+
+ public void dropProcedure(HplsqlParser.Drop_stmtContext ctx, String name,
boolean checkIfExists) {
+ if (checkIfExists && !function.exists(name)) {
+ trace(ctx, name + " DOES NOT EXIST");
+ return;
+ }
+ function.remove(name);
Review comment:
Ok let's rename it.
Just some context: the name was inherited from the existing implementation,
I hope I can do some more refactoring after we dropped the in memory
implementations and only keep the HMS backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
