belugabehr commented on a change in pull request #1933:
URL: https://github.com/apache/hive/pull/1933#discussion_r568066289



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/MemoryInfo.java
##########
@@ -46,30 +48,25 @@ public MemoryInfo(Configuration conf) {
       llapInfo.initClusterInfo();
       if (llapInfo.hasClusterInfo()) {
         this.maxExecutorMemory = llapInfo.getMemoryPerExecutor();
+        LOG.info("Using LLAP registry executor MB {}", maxExecutorMemory / 
(1024L * 1024L));

Review comment:
       This just does not look correct to me.
   
   Are you trying to log the value here in MB?  I think 
`this.maxExecutorMemory` is in MB already.  It is currently TB to MB with this 
large divisor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to