szlta commented on a change in pull request #1951:
URL: https://github.com/apache/hive/pull/1951#discussion_r571977069
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -229,11 +230,20 @@ public void debugDumpShort(StringBuilder sb) {
new LinkedBlockingQueue<Runnable>(),
new
ThreadFactoryBuilder().setNameFormat("IO-Elevator-Thread-%d").setDaemon(true).build());
FixedSizedObjectPool<IoTrace> tracePool = IoTrace.createTracePool(conf);
+ if (isEncodeEnabled) {
Review comment:
Making the encode threads pooled has little advantage on its own, but is
required for the accurate buffer accounting part - moreover the two change
parts are quite small, so I thought it makes sense to combine them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
