[GitHub] [hive] aasha commented on a change in pull request #1855: HIVE-24624: Repl Load should detect the compatible staging dir

[GitBox]

aasha commented on a change in pull request #1855:
URL: https://github.com/apache/hive/pull/1855#discussion_r573464291



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -398,11 +398,8 @@ private Path getCurrentLoadPath() throws IOException, 
SemanticException {
   }
 
   private boolean shouldLoadProceed (Path hiveDumpPath) throws IOException {
-    if (hiveDumpPath != null) { // Is null check necessary?
-      return hiveDumpPath.getFileSystem(conf).exists(new Path(hiveDumpPath, 
ReplAck.DUMP_ACKNOWLEDGEMENT.toString()))
-          && !hiveDumpPath.getFileSystem(conf).exists(new Path(hiveDumpPath, 
LOAD_ACKNOWLEDGEMENT.toString()));
-    }
-    return false;
+    return hiveDumpPath.getFileSystem(conf).exists(new Path(hiveDumpPath, 
ReplAck.DUMP_ACKNOWLEDGEMENT.toString()))

Review comment:
       better to keep the check. If someone reuses the method, might lead to npe




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org