risdenk commented on a change in pull request #1969:
URL: https://github.com/apache/hive/pull/1969#discussion_r577075893
##########
File path: standalone-metastore/pom.xml
##########
@@ -123,6 +123,13 @@
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
Review comment:
After adding the `dependencyManagement` section, the `jackson.version`
for `jackson-databind` can be removed.
##########
File path: standalone-metastore/pom.xml
##########
@@ -123,6 +123,13 @@
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review comment:
This needs to be moved to a new `dependencyManagement` section above
`dependencies`.
##########
File path: testutils/ptest2/pom.xml
##########
@@ -115,20 +115,24 @@ limitations under the License.
<artifactId>velocity</artifactId>
<version>1.7</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review comment:
This needs to be moved to a `dependencyManagement` section above
`dependencies`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
