jcamachor commented on a change in pull request #1981:
URL: https://github.com/apache/hive/pull/1981#discussion_r577770512
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateIncrementalRewritingRule.java
##########
@@ -117,17 +116,17 @@ public void onMatch(RelOptRuleCall call) {
projExprs.add(rightRef);
joinConjs.add(rexBuilder.makeCall(SqlStdOperatorTable.EQUALS,
Review comment:
Instead of doing the transformation in the rewrite to AST method, let's
do it here. That will be more consistent and decrease rewriting at the AST
level.
In particular, this should be `SqlStdOperatorTable.IS_NOT_DISTINCT_FROM`.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateIncrementalRewritingRule.java
##########
@@ -117,17 +116,17 @@ public void onMatch(RelOptRuleCall call) {
projExprs.add(rightRef);
joinConjs.add(rexBuilder.makeCall(SqlStdOperatorTable.EQUALS,
ImmutableList.of(leftRef, rightRef)));
- filterConjs.add(rexBuilder.makeCall(SqlStdOperatorTable.IS_NULL,
Review comment:
In this case, this filter condition should be the same one that it is
introduced for the join operator (with
`SqlStdOperatorTable.IS_NOT_DISTINCT_FROM`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
