pvargacl edited a comment on pull request #2017: URL: https://github.com/apache/hive/pull/2017#issuecomment-785691173
I missing some features, should these part of this PR? - shouldn't the lock type changed from exclusive to excl_write if we use this kind of drop? - shouldn't he Cleaner later delete the whole partition directory if it was not recreated? - I think you should add many test, around drop and recreate, what happens if you recreate in different scenarios (while there is an old read still running, when you overlap with the cleaner, when it was already cleaned up ... - there will be a race condition in the cleaner and the create partition I think, what happens if Cleaner starts to run, checks if the partition was dropped, so decides it has to delete the partition directory, but now a create partition comes and a new query starts to write a new delta. This should be handled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
