pvary commented on a change in pull request #1992:
URL: https://github.com/apache/hive/pull/1992#discussion_r584043504
##########
File path: service/src/java/org/apache/hive/service/cli/operation/Operation.java
##########
@@ -326,6 +326,7 @@ protected synchronized void cleanupOperationLog(final long
operationLogCleanupDe
if (operationLogCleanupDelayMs > 0) {
scheduledExecutorService.schedule(new
OperationLogCleaner(operationLog), operationLogCleanupDelayMs,
TimeUnit.MILLISECONDS);
+ scheduledExecutorService.shutdown();
Review comment:
If I understand correctly, then the pool is created regardless of the
config. We might want to close outside of the conditional expressions. What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
