abstractdog edited a comment on pull request #1941: URL: https://github.com/apache/hive/pull/1941#issuecomment-788132782
> @abstractdog I still stand with what I wrote on the Jira. I do not understand why we have `overrideIntIfDefaultIsSet(conf, x, y, z);` in the code instead of putting `x=z` in hive-site.xml/tez-site.xml. We do not need any of this override logic. Why don't we just remove all the overriding madness and put the correct values in xml files? What am I missing? okay, I agree, honestly, I created the optional override logic because I assumed that these mini clusters are used somewhere else where someone relies on the fact that mini clusters can ensure proper settings (hive.tez.container.size != -1)...but if so, the above points you mentioned apply to those as well, so they should take care of the proper settings in XMLs or whatever before invoking minicluster initialization I'm about to refresh the patch by completely removing override logic ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
