belugabehr commented on pull request #2009: URL: https://github.com/apache/hive/pull/2009#issuecomment-788939546
@pgaref Thanks for your interest (as always). The Time parsing/formatting code is all over the place in Hive. Did you know there are some areas of the code that allow for 10 digits of nanos, by truncating the last digit, but not others? I am trying to consolidate all that stuff and bring it into one place for visibility and trying to harmonize it with the pre-canned ISO formats already included in the JDK. The less Hive-specific stuff regarding time handling, the better. I also plan on adding copious documentation once I get the unit tests all working. I know some of them are broken. I'm having a pretty hard time figuring out where they are going wrong. And yes `ISO_LOCAL_TIME` includes an optional NANO field. This will be mentioned in comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
