losipiuk opened a new pull request #2040:
URL: https://github.com/apache/hive/pull/2040


   ### What changes were proposed in this pull request?
   
   Fix reader leak in AvroGenericRecordReader
   
   ### Why are the changes needed?
   
   Without the fix resources may be slowly leaked if we hit exception path in 
AvroGenericRecordReader. 
   I specifically observed it in use of `AGRR` in 
https://github.com/trinodb/trino. Hitting problematic path resulted in leaking 
S3 connections.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Leaking resources may eventully result to application malfunction. That 
was observed in https://github.com/trinodb/trino which uses problematic class.
   
   ### How was this patch tested?
   
   Manually tested sibling change in forked class in 
https://github.com/trinodb/trino. It was done using a stress test which 
reproduced problem without change applied.
   With a change we no longer observed leaked connections.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to