pvary commented on a change in pull request #2040:
URL: https://github.com/apache/hive/pull/2040#discussion_r589348565
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java
##########
@@ -88,22 +88,38 @@ public AvroGenericRecordReader(JobConf job, FileSplit
split, Reporter reporter)
gdr.setExpected(latest);
}
- if (split.getLength() == 0) {
- this.isEmptyInput = true;
- this.start = 0;
- this.reader = null;
+ org.apache.avro.file.FileReader<GenericRecord> nonFinalReader = null;
+ try {
+ if (split.getLength() == 0) {
+ this.isEmptyInput = true;
+ this.start = 0;
+ this.reader = null;
+ } else {
+ this.isEmptyInput = false;
+ nonFinalReader = new DataFileReader<GenericRecord>(new
FsInput(split.getPath(), job), gdr);
+ this.reader = nonFinalReader;
+ this.reader.sync(split.getStart());
+ this.start = reader.tell();
Review comment:
Ok. Do I understand correctly that the problem is not with the
`DataFileReader` creation, but some other initialization in the
`AvroGenericRecordReader`? Basically what we want to do is make sure that we
free up the resources if the `AvroGenericRecordReader` creation is unsuccessful?
Then I do not understand the importance of the `nonFinalReader`. Could we
just set the reader at creation? Later, if it is set but there is an exception
then just close it before rethrowing the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
