pvary commented on a change in pull request #2058:
URL: https://github.com/apache/hive/pull/2058#discussion_r592306506
##########
File path:
iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java
##########
@@ -230,7 +231,8 @@ public void testDateType() {
public void testTimestampType() {
Literal<Long> timestampLiteral =
Literal.of("2012-10-02T05:16:17.123456").to(Types.TimestampType.withoutZone());
long timestampMicros = timestampLiteral.value();
- Timestamp ts =
Timestamp.valueOf(DateTimeUtil.timestampFromMicros(timestampMicros));
+ //
`org.apache.hadoop.hive.common.type.Timestamp.valueOf(lit.toString()).toSqlTimestamp()`
+ Timestamp ts =
Timestamp.from(DateTimeUtil.timestampFromMicros(timestampMicros).toInstant(ZoneOffset.UTC));
Review comment:
Same problem than with the comment in `HiveIcebergFilterFactory`
Either remove the comment, or rephrase it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
