belugabehr commented on a change in pull request #1963:
URL: https://github.com/apache/hive/pull/1963#discussion_r593811046
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java
##########
@@ -253,7 +259,7 @@ public int execute() {
counters = mergedCounters;
} catch (Exception err) {
// Don't fail execution due to counters - just don't print summary
info
- LOG.warn("Failed to get counters. Ignoring, summary info will be
incomplete. " + err, err);
+ LOG.warn("Failed to get counters. Ignoring, summary info will be
incomplete.", err);
Review comment:
Nope. Removing this was intentional. SLF4J will log the entire
Exception information, no need to print it twice.
Edit: Or, perhaps you mean missing the anchor `{}` for err. If the last
variable is an Exception, SL4J will handle it specially, no need to explicitly
call it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
