hsnusonic commented on a change in pull request #2073: URL: https://github.com/apache/hive/pull/2073#discussion_r596462319
########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ########## @@ -3585,6 +3532,77 @@ public ShowCompactResponse showCompact(ShowCompactRequest rqst) throws MetaExcep } } + @RetrySemantics.ReadOnly + public GetLatestCompactionResponse getLatestCompaction(GetLatestCompactionRequest rqst) throws MetaException { + GetLatestCompactionResponse response = new GetLatestCompactionResponse(); + response.setDbname(rqst.getDbname()); + response.setTablename(rqst.getTablename()); + Connection dbConn = null; + PreparedStatement pst = null; + try { Review comment: In the latest change, I closed the connection, statement, resultset in the finally block as some other methods in this file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org