asinkovits commented on a change in pull request #2066:
URL: https://github.com/apache/hive/pull/2066#discussion_r596663012
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java
##########
@@ -369,6 +372,13 @@ public GetTokenResponseProto
getDelegationToken(RpcController controller,
return responseProtoBuilder.build();
}
+ @Override
+ public GetCacheContentResponseProto getCacheContent(RpcController controller,
+ GetCacheContentRequestProto request) {
+ CacheEntryList entries = LlapProxy.getIo().fetchCachedMetadata();
Review comment:
For the sake of con consistency, i think its better to return an empty
response rather than a null. All rpc calls in the api do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
