pvargacl commented on a change in pull request #2086:
URL: https://github.com/apache/hive/pull/2086#discussion_r596707252



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -545,6 +556,8 @@ protected Boolean findNextCompactionAndExecute(boolean 
computeStats) throws Inte
 
         heartbeater.cancel();
 
+        failAfterCompactionIfSetForTest();

Review comment:
       instead of introducing this test only code here, you could use 
Mockito.spy in the test and override verifyTableIdHasNotChanged to always throw 
exception, that would have the same effect (probably you need the change the 
visibility to protected)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to