zeroflag commented on a change in pull request #2059:
URL: https://github.com/apache/hive/pull/2059#discussion_r597539014
##########
File path: hplsql/src/test/results/local/func_no_return.out.txt
##########
@@ -0,0 +1 @@
+Ln:1 identifier 'CREATE' must be declared.
Review comment:
Yes, generated parsers rarely give very good error messages unlike
handwritten parsers. I think it is still an improvement over what we used to
have (silently ignored incorrect syntax). If you have an idea how to make antlr
emit better error messages please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
