vihangk1 commented on a change in pull request #2094:
URL: https://github.com/apache/hive/pull/2094#discussion_r599792900
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java
##########
@@ -695,7 +695,8 @@ public Database transformDatabase(Database db, List<String>
processorCapabilitie
if (!isTenantBasedStorage) {
Path locationPath = Path.getPathWithoutSchemeAndAuthority(new
Path(db.getLocationUri()));
Path whRootPath =
Path.getPathWithoutSchemeAndAuthority(hmsHandler.getWh().getWhRoot());
- if (FileUtils.isSubdirectory(whRootPath.toString(),
locationPath.toString())) { // legacy path
+ LOG.debug("Comparing DB and warehouse paths warehouse={}
db.getLocationUri={}", whRootPath.toString(), locationPath.toString());
+ if (FileUtils.isSubdirectory(whRootPath.toString(),
locationPath.toString()) || locationPath.equals(whRootPath)) { // legacy path
Review comment:
It is unclear to me why we set the managedLocationUri in this if block.
It looks like if the db location is under warehouse location we will be setting
managed location same as the db location. Why is that needed? A comment here
about the reasoning for this would be very helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
