jcamachor commented on a change in pull request #2027:
URL: https://github.com/apache/hive/pull/2027#discussion_r601016092
##########
File path: ql/src/test/results/clientpositive/llap/compare_cols_null.q.out
##########
@@ -34,8 +34,9 @@ STAGE PLANS:
Processor Tree:
TableScan
alias: ccn_table
+ filterExpr: (key > '123a') (type: boolean)
Filter Operator
- predicate: false (type: boolean)
+ predicate: (key > '123a') (type: boolean)
Review comment:
@dengzhhu653 , that's a great point. The path moving forward should be
to fold/optimize this type of expressions in the optimizer (Calcite) rather
than in `TypeCheckProcFactory.java`. It seems we have a gap in the optimization
logic, that's why it's not getting folded. @scarlin-cloudera , could you create
a follow-up JIRA to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
