deniskuzZ commented on a change in pull request #2132:
URL: https://github.com/apache/hive/pull/2132#discussion_r605452311



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -4579,13 +4585,16 @@ private int abortTxns(Connection dbConn, List<Long> 
txnids, boolean checkHeartbe
       TxnUtils.buildQueryWithINClause(conf, queries, prefix, suffix, txnids, 
"\"HL_TXNID\"", false, false);
 
       // execute all queries in the list in one batch
+      int numAborted = 0;
       if (skipCount) {

Review comment:
       When we abort a single txn, skipCount=true, so we might get very 
inaccurate values here. Probably we should return count in 
abortTxn(AbortTxnRequest rqst) as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to