adesh-rao commented on a change in pull request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r608511275
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
##########
@@ -2476,6 +2499,25 @@ public boolean isTableConstraintValid(String catName,
String dbName, String tblN
return isValid;
}
+ public boolean isTableCacheStale(String catName, String dbName, String
tblName, String validWriteIdList) {
+ boolean isValid = false;
+
+ if (StringUtils.isEmpty(validWriteIdList))
+ return false;
Review comment:
nit: add braces.
Also, should we return true? if validWriteId is not present, we can assume
that table is not loaded properly and it should be fetched from metastore db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
