vnhive commented on a change in pull request #2162:
URL: https://github.com/apache/hive/pull/2162#discussion_r610452112
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java
##########
@@ -203,7 +203,7 @@ public boolean isTableNotExistsError(SQLException e) {
* Whether the RDBMS has restrictions on IN list size (explicit, or poor
perf-based).
*/
protected boolean needsInBatching() {
- return isORACLE() || isSQLSERVER();
+ return isORACLE() || isSQLSERVER() || isPOSTGRES();
Review comment:
Setting hive.metastore.direct.sql.batch.size should have the same effect
as this fix. We can just ask the customer to set this configuration variable
instead of needing this fix.
This was the reason I did not submit a PR with this fix in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
