aasha commented on a change in pull request #2154:
URL: https://github.com/apache/hive/pull/2154#discussion_r609321577



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
##########
@@ -45,6 +45,14 @@ public DropPartitionEvent (Table table,
     this.deleteData = deleteData;
   }
 
+  public DropPartitionEvent(Table table, Iterable<Partition> partition, 
boolean status, boolean deleteData,
+      IHMSHandler handler) {
+    super(status, handler);
+    this.table = table;
+    this.partitions = partition;

Review comment:
       rename to partitions

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionOperation.java
##########
@@ -120,6 +126,12 @@ private void dropPartitions() throws HiveException {
     List<Partition> droppedPartitions = 
context.getDb().dropPartitions(tablenName.getDb(), tablenName.getTable(),
         partitionExpressions, options);
 
+    if (isRepl) {

Review comment:
       what is this check




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to