marton-bod commented on a change in pull request #2161:
URL: https://github.com/apache/hive/pull/2161#discussion_r610624208
##########
File path:
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -121,6 +121,9 @@ public void configureJobConf(TableDesc tableDesc, JobConf
jobConf) {
if (tableDesc != null && tableDesc.getProperties() != null &&
tableDesc.getProperties().get(WRITE_KEY) != null) {
jobConf.set("mapred.output.committer.class",
HiveIcebergOutputCommitter.class.getName());
+ // this will turn off job committing on the Tez AM side, so that we can
commit the write jobs
+ // on HS2 side instead using the HiveIcebergMetaHook
+ jobConf.set("hive.tez.mapreduce.output.committer.class", "");
Review comment:
I replaced the string key with the constant. As for using a null
committer, that class would need to extend the `OutputCommitter` from the
`tez-api` package. Currently iceberg-handler does not depend on Tez, so we can
only achieve that if we introduce that dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
