pgaref commented on a change in pull request #2165:
URL: https://github.com/apache/hive/pull/2165#discussion_r611548683



##########
File path: 
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -1386,8 +1386,9 @@ boolean isRequestedHostPresent(TaskInfo request) {
    */
   private SelectHostResult selectHost(TaskInfo request) {
     String[] requestedHosts = request.requestedHosts;
-    String requestedHostsDebugStr = Arrays.toString(requestedHosts);
+    String requestedHostsDebugStr = null;
     if (LOG.isDebugEnabled()) {
+      requestedHostsDebugStr = Arrays.toString(requestedHosts);

Review comment:
       Lets add a comment here mentioning that requestedHostsDebugStr should be 
properly assigned on the FIRST isDebugEnabled block.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to