pgaref commented on a change in pull request #1778:
URL: https://github.com/apache/hive/pull/1778#discussion_r612334078
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
##########
@@ -797,16 +803,17 @@ public void messageReceived(ChannelHandlerContext ctx,
MessageEvent evt)
Map<String, MapOutputInfo> mapOutputInfoMap =
new HashMap<String, MapOutputInfo>();
- Channel ch = evt.getChannel();
-
+ Channel ch = ctx.channel();
// In case of KeepAlive, ensure that timeout handler does not close
connection until entire
// response is written (i.e, response headers + mapOutput).
- ChannelPipeline pipeline = ch.getPipeline();
+ ChannelPipeline pipeline = ch.pipeline();
TimeoutHandler timeoutHandler =
(TimeoutHandler)pipeline.get(TIMEOUT_HANDLER);
timeoutHandler.setEnabledTimeout(false);
String user = userRsrc.get(jobId);
-
+ if (keepAliveParam || connectionKeepAliveEnabled){
Review comment:
Got it, this is helpful but lets make sure this is expected from nettys'
side of things before committing -- this would be helpful for the Tez change as
well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
