lcspinter opened a new pull request #2173:
URL: https://github.com/apache/hive/pull/2173
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Running ALTER TABLE ... SET
TBLPROPERTIES('storage_handler'='org.apache.iceberg.mr.hive.HiveIcebergStorageHandler')
should convert the data into iceberg format.
What is covered in this PR:
* Introduce new `commitAlterTable` hook
* update alterTable functions on HMSClient side to call the hook pre and
commit alter table hook methods
* provide `preAlterTable` hook implementation on HiveIcebergMetaHook side,
which does the following:
* check for existing iceberg tables, and if the check fails it means that
the iceberg table was not yet created
* validate that the source hms table is external, non-bucketed,
non-temporary and non-acid
* collect schema, partitionspec, location, format metadata needed for
data migration
* if the hms table is partitioned, remove the partition keys from it, and
add them as standard columns. Iceberg only have support for identity
partitioned tables.
* update input/output format and serde with iceberg ones.
* provide `commitAlterTable` hook implementation, which takes care of the
iceberg table creation and data migration
* create utility classes `HiveTableUtil` and `DataUtil`which collect the
data files under the table/partition directories and updates the iceberg
metadata files.
* introduced new q tests
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
This change would be useful when trying to read native hive table data
through Iceberg (for ex: airlines data)
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Manual test, Q test
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
