marton-bod commented on a change in pull request #2169:
URL: https://github.com/apache/hive/pull/2169#discussion_r612521207



##########
File path: pom.xml
##########
@@ -64,8 +64,7 @@
     <module>standalone-metastore</module>
     <module>upgrade-acid</module>
     <module>kafka-handler</module>
-    <module>iceberg-handler</module>
-    <module>iceberg-catalog</module>
+    <module>iceberg</module>

Review comment:
       Just to check, after this refactor, the handler and catalog jars are 
still packaged into the `packaging/target/.../lib` directory? How about the 
patched jars (core and api)? Are they correctly included into the shaded 
handler jar with the patched classfiles, but the patches jars are not included 
into the packaging `/lib`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to