deniskuzZ commented on a change in pull request #2089:
URL: https://github.com/apache/hive/pull/2089#discussion_r613076327
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -2419,9 +2419,9 @@ private void create_table_core(final RawStore ms, final
CreateTableRequest req)
}
if (!TableType.VIRTUAL_VIEW.toString().equals(tbl.getTableType())) {
- if (tbl.getSd().getLocation() == null
- || tbl.getSd().getLocation().isEmpty()) {
- tblPath = wh.getDefaultTablePath(db, tbl);
+ if (tbl.getSd().getLocation() == null ||
tbl.getSd().getLocation().isEmpty()) {
+ String relPath = tbl.getTableName() + (tbl.isSetTxnId() ? "_v" +
tbl.getTxnId() : "");
Review comment:
I think, <TABLE_NAME>/v_<TXN_ID> would be even more confusing + we would
need to take care of the <TABLE_NAME> folder if 0 versions remained.
Also when removing old style table path we would need to filter out new
table version folders if any.
><WAREHOUSE_ROOT>/<DB_NAME>.db/<TABLE_NAME>/v_12/delta_000013_000015
><WAREHOUSE_ROOT>/<DB_NAME>.db/<TABLE_NAME>/delta_00001_000011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
