deniskuzZ commented on a change in pull request #2182:
URL: https://github.com/apache/hive/pull/2182#discussion_r616575762



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/MetricsConstants.java
##########
@@ -23,7 +23,9 @@
   public static final String COMPACTION_STATUS_PREFIX = "compaction_num_";
   public static final String COMPACTION_OLDEST_ENQUEUE_AGE = 
"compaction_oldest_enqueue_age_in_sec";
   public static final String COMPACTION_INITIATOR_CYCLE = 
"compaction_initiator_cycle";
+  public static final String COMPACTION_FAILED_INITIATOR_CYCLE = 
"compaction_failed_initiator_cycle";

Review comment:
       I would rename both metrics to 
COMPACTION_FAILED_INITIATOR_RATIO(compaction_failed_initiator_ratio), 
COMPACTION_FAILED_CLEANER_RATIO(compaction_failed_cleaner_ratio)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to