pvary commented on a change in pull request #2161:
URL: https://github.com/apache/hive/pull/2161#discussion_r617487622



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -239,6 +252,16 @@ public void abortJob(JobContext originalContext, int 
status) throws IOException
     cleanup(jobContext, jobLocations);
   }
 
+  private Set<FileStatus> listForCommits(JobConf jobConf, String jobLocation) 
throws IOException {

Review comment:
       nit: Maybe a javadoc that do not use it for anything else than abort.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to