ashish-kumar-sharma commented on a change in pull request #2153:
URL: https://github.com/apache/hive/pull/2153#discussion_r617535115
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -2381,82 +2381,141 @@ public Partition getPartitionWithAuthInfo(String
catName, String dbName, String
return
deepCopy(FilterUtils.filterPartitionIfEnabled(isClientFilterEnabled,
filterHook, p));
}
+ /**
+ * @deprecated use getTable(GetTableRequest getTableRequest)
+ * @param dbname
+ * @param name
+ * @return
+ * @throws TException
+ */
@Override
+ @Deprecated
public Table getTable(String dbname, String name) throws TException {
- return getTable(getDefaultCatalog(conf), dbname, name);
+ GetTableRequest req = new GetTableRequest(dbname, name);
+ req.setCatName(getDefaultCatalog(conf));
+ return getTable(req);
}
+ /**
+ * @deprecated use getTable(GetTableRequest getTableRequest)
+ * @param dbname
+ * @param name
+ * @param getColumnStats
+ * get the column stats, if available, when true
+ * @param engine engine sending the request
+ * @return
+ * @throws TException
+ */
@Override
+ @Deprecated
public Table getTable(String dbname, String name, boolean getColumnStats,
String engine) throws TException {
- return getTable(getDefaultCatalog(conf), dbname, name, getColumnStats,
engine);
+ GetTableRequest req = new GetTableRequest(dbname, name);
+ req.setCatName(getDefaultCatalog(conf));
+ req.setGetColumnStats(getColumnStats);
+ if (getColumnStats) {
Review comment:
Because in Table getTable(GetTableRequest getTableRequest) assume that
getTableRequest has valid data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
