jcamachor commented on a change in pull request #2163:
URL: https://github.com/apache/hive/pull/2163#discussion_r622313451
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
##########
@@ -788,6 +789,9 @@ public ASTNode visitCall(RexCall call) {
}
}
break;
+ case IS_DISTINCT_FROM:
+ // convert IS DISTINCT FROM to NOT (IS NOT DISTINCT FROM)
+ return visitCall((RexCall)
RexUtil.not(rexBuilder.makeCall(SqlStdOperatorTable.IS_NOT_DISTINCT_FROM,
call.getOperands())));
Review comment:
Do you still need to add `is_not_distinct_from` in FunctionRegistry.java
after this change? The reason why I am asking is that adding it to
FunctionRegistry will make it user facing, hopefully we can avoid that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
