sankarh commented on a change in pull request #2065:
URL: https://github.com/apache/hive/pull/2065#discussion_r622334824
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
##########
@@ -682,11 +685,8 @@ private void processCurrentEvents(EventState e,
WmThreadSyncWork syncWork) throw
// as possible
Map<WmTezSession, WmEvent> recordMoveEvents = new HashMap<>();
for (MoveSession moveSession : e.moveSessions) {
- if (HiveConf.getBoolVar(conf, ConfVars.HIVE_SERVER2_WM_DELAYED_MOVE)) {
- handleMoveSessionOnMasterThread(moveSession, syncWork,
poolsToRedistribute, e.toReuse, recordMoveEvents, true);
- } else {
- handleMoveSessionOnMasterThread(moveSession, syncWork,
poolsToRedistribute, e.toReuse, recordMoveEvents, false);
- }
+ handleMoveSessionOnMasterThread(moveSession, syncWork,
poolsToRedistribute, e.toReuse,
Review comment:
Shall store the HiveConf.getBoolVar(conf,
ConfVars.HIVE_SERVER2_WM_DELAYED_MOVE) in a boolean variable outside the "for"
loop and use it here.
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3753,11 +3753,12 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
"Determines behavior of the wm move trigger when destination pool is
full.\n" +
"If true, the query will run in source pool as long as possible if
destination pool is full;\n" +
"if false, the query will be killed if destination pool is full."),
-
HIVE_SERVER2_WM_DELAYED_MOVE_TIMEOUT("hive.server2.wm.delayed.move.timeout",
"600",
+
HIVE_SERVER2_WM_DELAYED_MOVE_TIMEOUT("hive.server2.wm.delayed.move.timeout",
"3600",
new TimeValidator(TimeUnit.SECONDS),
"The amount of time a delayed move is allowed to run in the source
pool,\n" +
- "when a delayed move session times out, the session is moved to the
destination pool.\n"),
-
HIVE_SERVER2_WM_DELAYED_MOVE_VALIDATOR_INTERVAL("hive.server2.wm.delayed.move.validator.interval",
"10",
+ "when a delayed move session times out, the session is moved to the
destination pool.\n" +
+ "A value of 0 indicates no timeout"),
+
HIVE_SERVER2_WM_DELAYED_MOVE_VALIDATOR_INTERVAL("hive.server2.wm.delayed.move.validator.interval",
"60",
new TimeValidator(TimeUnit.SECONDS),
"Interval for checking for expired delayed moves and retries. Value of
0 indicates no checks."),
Review comment:
I think, we shouldn't allow 0 for interval. It creates confusion as we
set timeout but it doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
