pgaref commented on a change in pull request #2225:
URL: https://github.com/apache/hive/pull/2225#discussion_r623972738
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java
##########
@@ -414,16 +423,35 @@ protected int computeStartPreceding(int rowIdx,
PTFPartition p) throws HiveExcep
return r + 1;
}
else { // Use Case 5.
+ Pair<Integer, Object> start = binaryPreSearchBack(r, p, sortKey, rowVal,
amt);
+ //start again with linear search from the last point where
!isDistanceGreater was true
+ r = start.getLeft();
+ rowVal = start.getRight();
while (r >= 0 && !isDistanceGreater(sortKey, rowVal, amt) ) {
Pair<Integer, Object> stepResult = skipOrStepBack(r, p);
r = stepResult.getLeft();
rowVal = stepResult.getRight();
}
-
return r + 1;
}
}
+ private Pair<Integer, Object> binaryPreSearchBack(int r, PTFPartition p,
Object sortKey,
Review comment:
I guess existing PTF tests should covert this optimization but would be
great if we would add specific ones for cases 4 and 5 above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
