jcamachor commented on a change in pull request #2231:
URL: https://github.com/apache/hive/pull/2231#discussion_r626149398
##########
File path: ql/src/test/results/clientpositive/llap/acid_no_buckets.q.out
##########
@@ -810,18 +810,18 @@ STAGE PLANS:
Statistics: Num rows: 500 Data size: 265500 Basic stats:
COMPLETE Column stats: PARTIAL
Reduce Output Operator
key expressions: _col0 (type:
struct<writeid:bigint,bucketid:int,rowid:bigint>)
- null sort order: z
+ null sort order: a
Review comment:
I don't think it will have any impact (row_id should not be null) but
why is null order changing? I do not see any related change in your changes?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -6945,6 +6941,16 @@ else if (acidOp == Operation.NOT_ACID || acidOp ==
Operation.INSERT) {
return input;
}
+ // SORT BY ROW__ID ASC
+ private List<Integer> createSortOrderForUpdateDelete(List<ExprNodeDesc>
sortCols) {
+ List<Integer> sortOrders;
Review comment:
Can be merged with next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
