pkumarsinha commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630468790
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -681,6 +682,7 @@ private int executeIncrementalLoad() throws Exception {
}
this.childTasks.addAll(childTasks);
createReplLoadCompleteAckTask();
+ LOG.info("REPL_INCREMENTAL_LOAD duration : {} ms",
System.currentTimeMillis() - loadStartTime);
Review comment:
Does schedule instance ID gets printed here? If not how do we related
this message to the policy?
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
private String dumpDir;
private long numEvents;
private long eventSeqNo;
+ private long currentEventTimestamp;
Review comment:
Tracking the timing insider the logger may not be a great idea. Time
taken for an event should be an input given to the logger from outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
