belugabehr commented on a change in pull request #2269:
URL: https://github.com/apache/hive/pull/2269#discussion_r631883645
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
##########
@@ -160,10 +160,11 @@
* @param catName name of the catalog to alter.
* @param cat new version of the catalog.
* @throws MetaException something went wrong, usually in the database.
+ * @throws NoSuchObjectException no catalog of this name exists.
* @throws InvalidOperationException attempt to change something about the
catalog that is not
* changeable, like the name.
*/
- void alterCatalog(String catName, Catalog cat) throws MetaException,
InvalidOperationException;
+ void alterCatalog(String catName, Catalog cat) throws MetaException,
NoSuchObjectException, InvalidOperationException;
Review comment:
This should also throw NoSuchObjectException if user is attempting to
alter a non-existing catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
