hsnusonic commented on a change in pull request #2272: URL: https://github.com/apache/hive/pull/2272#discussion_r632845951
########## File path: ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandlerWithOneConnection.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore.txn; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.api.GetValidWriteIdsRequest; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.hadoop.hive.metastore.utils.TestTxnDbUtil; +import org.apache.logging.log4j.Level; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.core.LoggerContext; +import org.apache.logging.log4j.core.config.Configuration; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Collections; + +/** + * Tests to ensure function works even with connection pool size is 1 + */ +public class TestTxnHandlerWithOneConnection { + static final private String CLASS_NAME = TxnHandler.class.getName(); + private static final Logger LOG = LoggerFactory.getLogger(CLASS_NAME); + + private HiveConf conf = new HiveConf(); + private TxnStore txnHandler; + + public TestTxnHandlerWithOneConnection() throws Exception { + TestTxnDbUtil.setConfValues(conf); + TestTxnDbUtil.prepDb(conf); + LoggerContext ctx = (LoggerContext) LogManager.getContext(false); + Configuration conf = ctx.getConfiguration(); + conf.getLoggerConfig(CLASS_NAME).setLevel(Level.DEBUG); + ctx.updateLoggers(conf); + tearDown(); + } + + @Test + public void testGetValidWriteIds() throws Exception { + GetValidWriteIdsRequest req = new GetValidWriteIdsRequest(); + req.setFullTableNames(Collections.singletonList("foo.bar")); + txnHandler.getValidWriteIds(req); Review comment: In the [setUp](https://github.com/apache/hive/pull/2272/files/841a9dbcd268a752eeb2bd8c94b31b60e2745110#diff-1330cca7fba34e1fbab08b3ed7868a78701b956c2af276476c3ae282976e0de7R64), the connection pool is set to have only one connection. If it request for the second connection, it will fail right away with timeout since I set the timeout to be 250 millisecond. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
