abstractdog commented on a change in pull request #2099:
URL: https://github.com/apache/hive/pull/2099#discussion_r633453402
##########
File path:
ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt
##########
@@ -34,20 +34,17 @@ public class <ClassName> extends VectorExpression {
private static final long serialVersionUID = 1L;
- private final int colNum1;
private final int colNum2;
Review comment:
what do you think about this @ramesh0201?
I think a general input col array would be nice (option b) )
however, there some rare cases where it's not obvious which position should
be used, but it's up to agreement e.g.:
IfExprScalarColumn.txt
```
protected final int arg1Column;
protected final <OperandType2> arg2Scalar;
protected final int arg3Column;
```
this is tricky because there is a scalar interleaved into the columns, input
col array might look like:
1. new int[] { arg1Column, -1, arg3Column};
to emphasize that that the second argument is a scalar, so we'll refactor as:
```
arg3Column => inputColumnNums[2]
```
2. new int[] { arg1Column, arg3Column, -1};
to ignore the fact that there is an interleaved scalar input, so we'll
refactor as:
```
arg3Column => inputColumnNums[1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
