asinkovits commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r635843838
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSMetricsListener.java
##########
@@ -86,4 +92,24 @@ public void onAddPartition(AddPartitionEvent partitionEvent)
throws MetaExceptio
Metrics.getOrCreateGauge(MetricsConstants.TOTAL_PARTITIONS).incrementAndGet();
createdParts.inc();
}
+
+ @Override
+ public void onAllocWriteId(AllocWriteIdEvent allocWriteIdEvent, Connection
dbConn, SQLGenerator sqlGenerator) throws MetaException {
+ Table table = getTable(allocWriteIdEvent);
Review comment:
Yeah, if i understand correctly this was already done in a tricky way.
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L482
The listener is only added if the metrics registry is initialized, which is
only done when metrics are enabled.
Do you think we should explicitly add the check here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
